Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] otel context injection #133

Merged
merged 8 commits into from
Dec 24, 2024
Merged

[Feature] otel context injection #133

merged 8 commits into from
Dec 24, 2024

Conversation

yotamloe
Copy link
Contributor

@yotamloe yotamloe commented Dec 24, 2024 •
edited
Loading

Description

2.2.0

  • Add addOtelContext configuration option:
    • trace_id, span_id, service_name fields to logs when opentelemetry context is available.

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

@yotamloe yotamloe requested review from 8naama and ralongit December 24, 2024 07:10
8naama
8naama approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💪🏼🥳

Perhaps we can add a short sentence or link in the README explaining how to enable the OpenTelemetry context, for those who might not be familiar with instrumentation options

ralongit
ralongit approved these changes Dec 24, 2024
View reviewed changes
Copy link

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
+1 on adding a section to the readme file & docs

@yotamloe yotamloe merged commit aa64f08 into master Dec 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8naama 8naama 8naama approved these changes

@ralongit ralongit ralongit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yotamloe @ralongit @8naama